Skip to content

Conversation

@maciejwalkowiak
Copy link
Contributor

📜 Description

Bind external properties to a dedicated ExternalOptions class.

💡 Motivation and Context

This allows to turn nullable Boolean fields from SentryOptions into a non-nullable boolean and keep simple getter and setter, without breaking Java beans standard.

Fixes #1738.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

This allows to turn nullable `Boolean` fields from SentryOptions into a non-nullable `boolean` and keep simple getter and setter, without breaking Java beans standard.

Fixes #1738.
@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review October 4, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants